Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Fix the RemoteAddressTest in the TCK by providing a resolved IP address #1637

Merged
merged 2 commits into from
Mar 8, 2023
Merged

test: Fix the RemoteAddressTest in the TCK by providing a resolved IP address #1637

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c3055f
Fix the RemoteAddressTest in the TCK by providing a resolved IP address
timyates Mar 7, 2023
8980b59
Merge branch 'master' into fix-remote-address-test
sdelamo Mar 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ...ws-api-proxy/src/test/java/io/micronaut/http/server/tck/lambda/LambdaServerUnderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import com.amazonaws.serverless.exceptions.ContainerInitializationException;
import com.amazonaws.serverless.proxy.internal.testutils.MockLambdaContext;
import com.amazonaws.serverless.proxy.model.ApiGatewayRequestIdentity;
import com.amazonaws.serverless.proxy.model.AwsProxyRequest;
import com.amazonaws.serverless.proxy.model.AwsProxyRequestContext;
import com.amazonaws.serverless.proxy.model.AwsProxyResponse;
Expand Down Expand Up @@ -63,7 +64,15 @@ private <I> AwsProxyRequest adaptRequest(HttpRequest<I> request) throws Unsuppor
AwsProxyRequest input = new AwsProxyRequest();
input.setHttpMethod(request.getMethodName());
input.setRequestContext(new AwsProxyRequestContext() {

@Override
public ApiGatewayRequestIdentity getIdentity() {
return new ApiGatewayRequestIdentity() {
@Override
public String getSourceIp() {
return "127.0.0.1";
}
};
}
});
input.setPath(request.getPath());
for (String headerName : request.getHeaders().names()) {
Expand Down
1 change: 0 additions & 1 deletion .../io/micronaut/http/server/tck/lambda/tests/MicronautLambdaHandlerHttpServerTestSuite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
@SelectPackages("io.micronaut.http.server.tck.tests")
@SuiteDisplayName("HTTP Server TCK for Function AWS API Proxy")
@ExcludeClassNamePatterns({
"io.micronaut.http.server.tck.tests.RemoteAddressTest", // CaptureRemoteAddressFiter throws NPE getting the address
"io.micronaut.http.server.tck.tests.filter.ResponseFilterTest",
"io.micronaut.http.server.tck.tests.filter.RequestFilterExceptionHandlerTest",
"io.micronaut.http.server.tck.tests.filter.ClientRequestFilterTest",
Expand Down