TCK: Add a mutable version of MicronautAwsProxyRequest #1638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the client filter TCK tests that mutate the request to pass. The Cookies were effectively mutable already (as they were simple cookies) To make parameters and headers mutable, I updated the Aws variants
|
SonarCloud Quality Gate failed. |
|
related commit in servlet micronaut-projects/micronaut-servlet@ab6eada |
|
This was done in servlet here micronaut-projects/micronaut-servlet@ab6eada |
yawkat
reviewed
Mar 7, 2023
| @Override | ||
| public MutableHttpHeaders add(CharSequence header, CharSequence value) { | ||
| String headerName = HttpHeaderUtils.normalizeHttpHeaderCase(header.toString()); | ||
| headers.computeIfAbsent(headerName, s -> new ArrayList<>()); |
There was a problem hiding this comment.
Suggested change
| headers.computeIfAbsent(headerName, s -> new ArrayList<>()); | |
| headers.computeIfAbsent(headerName, s -> new ArrayList<>()).add(value.toString()); |
yawkat
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the client filter TCK tests that mutate the request to pass.
The Cookies were effectively mutable already (as they were simple cookies)
To make parameters and headers mutable, I updated the Aws variants