#1687 Fix native image build with CloudWatchLoggingAppender #1688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Start the thread to send logs to cloudwatch only when append command is called, so it is not started during build time - Create dispatchOnStart property to return to previous behavior
|
Kudos, SonarCloud Quality Gate passed! |
graemerocher
approved these changes
Apr 19, 2023
n0tl3ss
approved these changes
Apr 19, 2023
|
@graemerocher Can we merge it? |
graemerocher
added
type: improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
appendmethod is called, instead ofstart. This way the thread is not started during build time, which is unsupported by native image. (See Cloudwatch logger appender doesn't work with native image #1687 for details).dispatchOnStartproperty to return to previous behavior if needed.