Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "add temporary @Ignore" #1696

Merged
merged 2 commits into from
Apr 26, 2023
Merged

Revert "add temporary @Ignore" #1696

merged 2 commits into from
Apr 26, 2023

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Apr 24, 2023

This reverts commit 4bec116.

@sdelamo
Copy link
Contributor Author

sdelamo commented Apr 24, 2023

@timyates can investigate this failure?

@timyates timyates mentioned this pull request Apr 25, 2023
Closed
@timyates
Copy link
Contributor

Blocked by bug in core: micronaut-projects/micronaut-core#9154

@timyates timyates added status: awaiting third-party Awaiting changes to a third party library and removed status: awaiting third-party Awaiting changes to a third party library labels Apr 25, 2023
@timyates
Copy link
Contributor

@sdelamo So this was a bug in core, which denis has now fixed

micronaut-projects/micronaut-core#9155
https://ge.micronaut.io/s/kf3qapojl3jv2/tests/:micronaut-function-client-aws:test/io.micronaut.function.client.aws.AwsLambdaInvokeSpec/test%20setup%20lambda%20config?top-execution=1

The test doesn't run on CI, but locally it will fail until we have an M3 release of core, and we update aws to use it

@sdelamo
Copy link
Contributor Author

sdelamo commented Apr 26, 2023

can you annotate the failing test with @PendingFeature and add @Issue with value micronaut-projects/micronaut-core#9155 and we will merge this Pr.

@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@timyates timyates merged commit 7a208ed into master Apr 26, 2023
@timyates timyates deleted the revert-ignore branch April 26, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@timyates timyates

Labels
None yet
Projects
No open projects
4.0.0-M3 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdelamo @timyates