Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS to M7 #1760

Merged
merged 13 commits into from
Jun 12, 2023
Merged

AWS to M7 #1760

merged 13 commits into from
Jun 12, 2023

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Jun 9, 2023

No description provided.

@timyates
Copy link
Contributor

timyates commented Jun 9, 2023

So it looks like a class io.micronaut.scheduling.instrument.ReactiveInvocationInstrumenterFactory has gone

Time for some code archaeology to see where and what it was replaced by...

@timyates
Copy link
Contributor

timyates commented Jun 9, 2023

Ahhh ok, so it was removed in micronaut-projects/micronaut-core#9346 but I guess it's still used in micronaut-reactor

I think we'll need micronaut-reactor-M6 for this to pass

(assuming it's micronaut-reactor that's pulling it in)

@timyates timyates added the status: awaiting third-party Awaiting changes to a third party library label Jun 9, 2023
@timyates timyates removed the status: awaiting third-party Awaiting changes to a third party library label Jun 9, 2023
@timyates
Copy link
Contributor

timyates commented Jun 9, 2023

@sdelamo

Updated to latest reactor, then the issue was that mongo pulls in an old validation which pulls in an old reactor

https://ge.micronaut.io/s/4ruzko746sala/dependencies?focusedDependency=WzEsNSw2NDAsWzEsNSxbNTAyLDYzMCw2NDBdXV0&toggled=W1sxXSxbMSw1XSxbMSw1LFs1MDJdXSxbMSw1LFs1MDIsNjMwXV0sWzEsNSxbNTAyLDYzMCw2NDBdXSxbMSw1LFs1MDIsNjMxXV1d

Excluded reactor from the mongo test dependency for now to get this green. I will look at getting a new version of Mongo together

@timyates timyates marked this pull request as ready for review June 9, 2023 12:08
@sdelamo sdelamo requested a review from timyates June 10, 2023 17:16
@sonarcloud
Copy link

sonarcloud bot commented Jun 11, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@timyates timyates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still can't find why the new test is failing

I suspect it's a bug in our test harness

Raised #1764

I see no reason to block this though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants