fix: request.getUri should respond include path and query values #1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see: #1848
sdelamo
changed the title
sdelamo
commented
Aug 29, 2023
...on-aws-api-proxy/src/main/java/io/micronaut/function/aws/proxy/ApiGatewayServletRequest.java
Show resolved
Hide resolved
driverpt
reviewed
Aug 29, 2023
| @@ -55,7 +55,11 @@ public APIGatewayV2HTTPEventServletRequest( | |||
| super( | |||
| conversionService, | |||
| requestEvent, | |||
| URI.create(requestEvent.getRequestContext().getHttp().getPath()), | |||
| ApiGatewayServletRequest.buildUri( | |||
| requestEvent.getRequestContext().getHttp().getPath(), | |||
There was a problem hiding this comment.
Why not use rawPath and rawQuery ?
There was a problem hiding this comment.
What would be the advantage of using rawPath and rawQuery? 🤔
There was a problem hiding this comment.
You don't need to parse and treat it
You can just join it, e.g.: ${path}?${query}
|
Kudos, SonarCloud Quality Gate passed! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see: #1848
I added the same test to the core TCK I have added a test in the TCK micronaut-projects/micronaut-core#9791