Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graal: remove static final Logger from DefaultHttpFactories #9189

Closed
wants to merge 1 commit into from

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented May 4, 2023

see: micronaut-projects/micronaut-starter#1773

I assume this PR fixes:

Error: Classes that should be initialized at run time got initialized during image building:
 org.slf4j.LoggerFactory was unintentionally initialized at build time. To see why org.slf4j.LoggerFactory got initialized use --trace-class-initialization=org.slf4j.LoggerFactory
io.micronaut.http.DefaultHttpFactories was unintentionally initialized at build time. To see why io.micronaut.http.DefaultHttpFactories got initialized use --trace-class-initialization=io.micronaut.http.DefaultHttpFactories
To see how the classes got initialized, use --trace-class-initialization=org.slf4j.LoggerFactory,io.micronaut.http.DefaultHttpFactories```
asses that should be initialized at run time got initialized during image building:
 io.micronaut.http.DefaultHttpFactories was unintentionally initialized at build time. io.micronaut.http.HttpResponseFactory caused initialization of this class with the following trace:
        at io.micronaut.http.DefaultHttpFactories.<clinit>(DefaultHttpFactories.java:37)
        at io.micronaut.http.HttpResponseFactory.<clinit>(HttpResponseFactory.java:29)

``

see: micronaut-projects/micronaut-starter#1773

```
Error: Classes that should be initialized at run time got initialized during image building:
 org.slf4j.LoggerFactory was unintentionally initialized at build time. To see why org.slf4j.LoggerFactory got initialized use --trace-class-initialization=org.slf4j.LoggerFactory
io.micronaut.http.DefaultHttpFactories was unintentionally initialized at build time. To see why io.micronaut.http.DefaultHttpFactories got initialized use --trace-class-initialization=io.micronaut.http.DefaultHttpFactories
To see how the classes got initialized, use --trace-class-initialization=org.slf4j.LoggerFactory,io.micronaut.http.DefaultHttpFactories```
``
```
asses that should be initialized at run time got initialized during image building:
 io.micronaut.http.DefaultHttpFactories was unintentionally initialized at build time. io.micronaut.http.HttpResponseFactory caused initialization of this class with the following trace:
        at io.micronaut.http.DefaultHttpFactories.<clinit>(DefaultHttpFactories.java:37)
        at io.micronaut.http.HttpResponseFactory.<clinit>(HttpResponseFactory.java:29)

``
@sdelamo sdelamo added type: bug Something isn't working relates-to: graal labels May 4, 2023
@sdelamo sdelamo requested a review from graemerocher May 4, 2023 10:11
@sdelamo
Copy link
Contributor Author

sdelamo commented May 4, 2023

No idea how to test this so that we catch it in core and not downstream.

@graemerocher
Copy link
Contributor

This is not the correct fix. What has to be understood is why this type is being initialized in the first place. There must be some initialize at build time flags somewhere

@sonarcloud
Copy link

sonarcloud bot commented May 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sdelamo sdelamo closed this May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relates-to: graal type: bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants