Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support more leniant enum parsing and support JsonValue on enum methods #298

Merged
merged 2 commits into from
Nov 2, 2022
Merged

Support more leniant enum parsing and support JsonValue on enum methods #298

merged 2 commits into from
Nov 2, 2022

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Nov 1, 2022

see #297

@sdelamo sdelamo changed the base branch from master to 1.3.x November 1, 2022 14:37
@sdelamo sdelamo linked an issue Nov 1, 2022 that may be closed by this pull request
Enum @JsonValue and readValue test works for jackson fails for serde #297
Closed
@graemerocher graemerocher changed the title test: PendingFeature for issue 297 More leniant enum parsing and support JsonValue on enum methods Nov 2, 2022
@graemerocher graemerocher changed the title More leniant enum parsing and support JsonValue on enum methods Support More leniant enum parsing and support JsonValue on enum methods Nov 2, 2022
@graemerocher graemerocher changed the title Support More leniant enum parsing and support JsonValue on enum methods Support more leniant enum parsing and support JsonValue on enum methods Nov 2, 2022
@graemerocher
Copy link
Contributor

implemented a fix for this

@graemerocher graemerocher added the type: improvement A minor improvement to an existing feature label Nov 2, 2022
@graemerocher graemerocher mentioned this pull request Nov 2, 2022
Closed
@sonarcloud
Copy link

sonarcloud bot commented Nov 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

85.2% 85.2% Coverage
0.0% 0.0% Duplication

@graemerocher graemerocher merged commit 0b59971 into 1.3.x Nov 2, 2022
@graemerocher graemerocher deleted the serdeenum branch November 2, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstepanov dstepanov dstepanov approved these changes

Assignees

@graemerocher graemerocher

Labels
type: improvement A minor improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enum @JsonValue and readValue test works for jackson fails for serde
3 participants
@sdelamo @graemerocher @dstepanov