Improve @JsonSubtypes Handling #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The names property is now used and merged with type name to be used for deserialization - The name property is used even if the subtype has @SerdeConfig annotation (in previous behavior the subtype annotation wasn't visited and therefore name wasn't used) - The JsonTypeName is prioritized over JsonSubtype name and names properties
|
SonarCloud Quality Gate failed. |
graemerocher
added
the
type: improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JsonSubtypes.Typenames property is now used and merged with type name to be used for deserialization@SerdeConfigannotation (in previous behavior the subtype annotation wasn't visited and therefore name wasn't used)@JsonTypeNameis prioritized over@JsonSubtypes.Typename and names propertiesExamples of jackson behavior in this tutorial: https://www.logicbig.com/tutorials/misc/jackson/json-type-info-with-logical-type-name.html