Support decoding base64 to byte[] #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackson-databind writes byte[] as base64 and supports reading from base64 or array. Serde 2 writes byte[] as array, but does not support reading from base64, so prior to this change we are only compatible with jackson in one direction (serde encoder -> jackson decoder). This patch adds decode support for base64, and for the bson binary type. For oracle jdbc json, a decodeBinary method already exists. On the encode side, there is now a config flag to use format-specific byte array encoding, which is base64 for json. The default remains to write an array of numbers. Fixes #520
alvarosanchez
approved these changes
Jul 19, 2023
graemerocher
requested changes
Jul 19, 2023
serde-api/src/main/java/io/micronaut/serde/config/SerdeConfiguration.java
Outdated
Show resolved
Hide resolved
serde-api/src/main/java/io/micronaut/serde/util/BinaryCodecUtil.java
Outdated
Show resolved
Hide resolved
serde-api/src/main/java/io/micronaut/serde/util/BinaryCodecUtil.java
Outdated
Show resolved
Hide resolved
|
SonarCloud Quality Gate failed.
|
alvarosanchez
requested changes
Jul 19, 2023
serde-support/src/test/groovy/io/micronaut/serde/support/CoreTypeSerdeSpec.groovy
Show resolved
Hide resolved
yawkat
added a commit
to micronaut-projects/micronaut-oracle-cloud
that referenced
this pull request
Sep 26, 2023
This enables the config option defined in micronaut-projects/micronaut-serialization#524 for the netty client. This test case still has SerdeImports that shouldn't be necessary. This seems to be an issue with the serde upgrade, I'm looking at it.
graemerocher
added a commit
to micronaut-projects/micronaut-oracle-cloud
that referenced
this pull request
Sep 28, 2023
* Use base64 for encoding byte arrays This enables the config option defined in micronaut-projects/micronaut-serialization#524 for the netty client. This test case still has SerdeImports that shouldn't be necessary. This seems to be an issue with the serde upgrade, I'm looking at it. * fix serialization inclusion too * fix broken serialization/deserialization --------- Co-authored-by: Graeme Rocher <graeme.rocher@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jackson-databind writes byte[] as base64 and supports reading from base64 or array. Serde 2 writes byte[] as array, but does not support reading from base64, so prior to this change we are only compatible with jackson in one direction (serde encoder -> jackson decoder).
This patch adds decode support for base64, and for the bson binary type. For oracle jdbc json, a decodeBinary method already exists.
On the encode side, there is now a config flag to use format-specific byte array encoding, which is base64 for json. The default remains to write an array of numbers.
Fixes #520