Support for @JsonDeserialize(builder=..) #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yawkat
reviewed
Jul 24, 2023
yawkat
approved these changes
Jul 24, 2023
|
what exactly are the pre-instantiate hooks used for (theyre used in data right)? i think builders should have the same behavior as creator methods wrt pre-instantiate hooks. i think atm the hook is called after the creator but before any more properties are set. |
|
I am not sure about these pre-instantiate hooks myself, @dstepanov will have to confirm |
|
The hook is used to perform possible validation before the constructor is invoked. In this case, we need to think about how we would trigger the builder method validation. |
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR for builder support, some open questions: