Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Field marked as READ_ONLY in JsonUnwrapped should not be writable #529

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Field marked as READ_ONLY in JsonUnwrapped should not be writable #529

merged 1 commit into from
Jul 24, 2023

Conversation

radovanradic
Copy link
Contributor

@radovanradic radovanradic commented Jul 24, 2023 •
edited
Loading

I think this was missed, we should not add prop to write properties if it belongs to @JsonUnwrapped and was marked as read only.

@sonarcloud
Copy link

sonarcloud bot commented Jul 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@graemerocher graemerocher added the type: improvement A minor improvement to an existing feature label Jul 24, 2023
@graemerocher graemerocher merged commit a8879c8 into master Jul 24, 2023
7 checks passed
@graemerocher graemerocher deleted the jsonunwrapped-readonly-prop branch July 24, 2023 18:08
@radovanradic radovanradic added this to the 2.1.1 milestone Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graemerocher graemerocher Awaiting requested review from graemerocher

Assignees
No one assigned
Labels
type: improvement A minor improvement to an existing feature
Projects
No open projects
4.0.2 Release
Status: Done
4.0.3 Release
Status: Done
Milestone
2.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@radovanradic @graemerocher