Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement correct generic arguments matcher #742

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Implement correct generic arguments matcher #742

merged 1 commit into from
Jan 30, 2024

Conversation

dstepanov
Copy link
Contributor

Fixes #690

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 30, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

3 New Critical Issues (required ≤ 0)
2 New Bugs (required ≤ 0)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@graemerocher
Copy link
Contributor

probably should run this through the Micronaut Data test suite to see if any coverage is missing here

@dstepanov dstepanov merged commit 29047c1 into master Jan 30, 2024
10 of 11 checks passed
@dstepanov dstepanov deleted the match branch January 30, 2024 17:07
@SpikeBlues SpikeBlues mentioned this pull request Jun 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graemerocher graemerocher graemerocher approved these changes

@yawkat yawkat Awaiting requested review from yawkat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deserializer for a collection with specific type breaks default generic collection deserializer
2 participants
@dstepanov @graemerocher