Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small improvements, refactoring + more tests #749

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Small improvements, refactoring + more tests #749

merged 1 commit into from
Feb 1, 2024

Conversation

dstepanov
Copy link
Contributor

Add a test that #402 is working.

Closes #402

@dstepanov dstepanov added the type: improvement A minor improvement to an existing feature label Feb 1, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
84.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@dstepanov dstepanov merged commit e63074b into master Feb 1, 2024
11 checks passed
@dstepanov dstepanov deleted the fixm branch February 1, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yawkat yawkat yawkat approved these changes

@graemerocher graemerocher Awaiting requested review from graemerocher

Assignees
No one assigned
Labels
type: improvement A minor improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected unset behaviour with custom deserializer
2 participants
@dstepanov @yawkat