Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to clone JacksonJsonMapper with a different SerdeJacksonConfiguration #778

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Allow to clone JacksonJsonMapper with a different SerdeJacksonConfiguration #778

merged 1 commit into from
Feb 27, 2024

Conversation

dstepanov
Copy link
Contributor

Fixes #170

@dstepanov dstepanov added the type: improvement A minor improvement to an existing feature label Feb 27, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@yawkat
Copy link
Member

yawkat commented Feb 27, 2024

do we need the interface

@dstepanov
Copy link
Contributor Author

I would prefer to have an interface instead of exposing JacksonJsonMapper to be public.

@yawkat
Copy link
Member

yawkat commented Feb 27, 2024

ok

@dstepanov dstepanov merged commit 77ce324 into master Feb 27, 2024
17 checks passed
@dstepanov dstepanov deleted the jacksonclone branch February 27, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graemerocher graemerocher graemerocher approved these changes

@yawkat yawkat yawkat approved these changes

Assignees
No one assigned
Labels
type: improvement A minor improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add comment support to json
3 participants
@dstepanov @yawkat @graemerocher