Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure micronaut-servlet works on Payara server #9

Closed
kbachl opened this issue Jun 4, 2020 · 0 comments
Closed

make sure micronaut-servlet works on Payara server #9

kbachl opened this issue Jun 4, 2020 · 0 comments
Labels
type: improvement A minor improvement to an existing feature

Comments

@kbachl
Copy link

kbachl commented Jun 4, 2020

Follow up to:
#7 and payara/Payara#4661

Payara server will always make a validation run of any war even CDI scanning is disabled. The io.micronaut.http.client.DefaultHttpClient.stop() with @PreDestroy while not beeing in any CDI will then lead to an error.
Since master of micronaut 2 changed that code part already it is necessary to add a test to make sure the micronaut-servlet runs on payara and therefore it works as expected.

Also the Documentation of micronaut-servlet should be enhanced making clear that it is important to no include Java EE dependencies like Servlet API, CDI API, etc into the war by making them scope provided. This might even be enforced by a check on compile-time by micronaut-servlet

@graemerocher graemerocher added the type: improvement A minor improvement to an existing feature label Jun 4, 2020
graemerocher added a commit to micronaut-projects/micronaut-core that referenced this issue Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: improvement A minor improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants