Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty response when an exception is thrown #737

Merged
merged 1 commit into from
Jun 16, 2024
Merged

Allow empty response when an exception is thrown #737

merged 1 commit into from
Jun 16, 2024

Conversation

andriy-dmytruk
Copy link
Contributor

No description provided.

This was referenced Jun 11, 2024
Merged
Closed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
77.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@graemerocher
Copy link
Contributor

could you add a test here?

@andriy-dmytruk
Copy link
Contributor Author

could you add a test here?

It would be hard to add a test, as I encountered the issue in oracle cloud and not here.
The only change is response to response == null ? null : response.toMutableResponse(), so it should be safe, though.

@graemerocher graemerocher merged commit 56776af into 4.9.x Jun 16, 2024
15 checks passed
@graemerocher graemerocher deleted the andriy/oracle-cloud-function-fixes branch June 16, 2024 06:36
@graemerocher graemerocher added the type: improvement A minor improvement to an existing feature label Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graemerocher graemerocher graemerocher approved these changes

Assignees
No one assigned
Labels
type: improvement A minor improvement to an existing feature
Projects
4.5.1 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andriy-dmytruk @graemerocher