Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to core InputStreamByteBody #770

Merged
merged 10 commits into from
Aug 19, 2024
Merged

Move to core InputStreamByteBody #770

merged 10 commits into from
Aug 19, 2024

Conversation

yawkat
Copy link
Member

@yawkat yawkat commented Aug 14, 2024

No description provided.

@yawkat yawkat added the type: improvement A minor improvement to an existing feature label Aug 14, 2024
@yawkat yawkat added this to the 4.10.0 milestone Aug 14, 2024
@yawkat yawkat requested a review from sdelamo August 14, 2024 08:28
* @author Jonas Konrad
*/
@Internal
public class ByteArrayBufferFactory implements ByteBufferFactory<Void, byte[]> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be I core?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe eventually but not needed yet

@sdelamo sdelamo mentioned this pull request Aug 19, 2024
Copy link

sonarcloud bot commented Aug 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
26.7% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

@sdelamo sdelamo merged commit b52f4c2 into 4.10.x Aug 19, 2024
14 of 15 checks passed
@sdelamo sdelamo deleted the inputstream-body branch August 19, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: improvement A minor improvement to an existing feature
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants