Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Issue with Tornado #873

Closed
named-user opened this issue Mar 9, 2018 · 3 comments
Closed

Version Issue with Tornado #873

named-user opened this issue Mar 9, 2018 · 3 comments

Comments

@named-user
Copy link

The latest version of Tornado (5.0) deprecates the ioloop, which is used with msgpack, resulting in an error when hello_drone.py is run.
Reverting to Tornado 4.5 solves the issue.
The issue seems related to the pip install of msgpack-rpc and its tornado dependencies.

Platform:
Linux
Offline
Manually installing dependencies

Error:

Traceback (most recent call last):
  File "./hello_drone.py", line 13, in <module>
    client = MultirotorClient()
  File "~/AirSim/PythonClient/AirSimClient.py", line 482, in __init__
    super(MultirotorClient, self).__init__(ip, 41451)
  File "~/AirSim/PythonClient/AirSimClient.py", line 196, in __init__
    self.client = msgpackrpc.Client(msgpackrpc.Address(ip, port), timeout = 3600, pack_encoding = 'utf-8', unpack_encoding = 'utf-8')
  File "/usr/local/lib/python3.5/dist-packages/msgpackrpc/client.py", line 15, in __init__
    loop.attach_periodic_callback(self.step_timeout, 1000) # each 1s
  File "/usr/local/lib/python3.5/dist-packages/msgpackrpc/loop.py", line 38, in attach_periodic_callback
    self._periodic_callback = ioloop.PeriodicCallback(callback, callback_time, self._ioloop)
TypeError: __init__() takes 3 positional arguments but 4 were given
@Lance804
Copy link

Thank you very much. I thought the tornado under 4.1 is needed, but it is conflict.

@sytelus
Copy link
Contributor

sytelus commented Mar 14, 2018

So what is the solution here? May be msgpack-rpc should force specific version?

Related: msgpack-rpc/msgpack-rpc-python#19

@sytelus
Copy link
Contributor

sytelus commented Apr 12, 2018

Looks like this is fixed: msgpack-rpc/msgpack-rpc-python#19

So if you update the package then it should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants