-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a more recent version of Tornado? #24
Comments
Seconded! |
I forked the repo and included the tornado code of version 4.5.3 (highest version <5) directly into it. Changed all the imports so it uses its own copy of tornado 4.5.3. This may not be the best solution, but for me it solves the issue. I can now use jupyterlab and notebook together with msgpack-rpc-python. The example works. It is hard to interrupt the server side tho... https://github.com/xaedes/msgpack-rpc-python/tree/with_tornado_453 To use it, just clone it and checkout the branch Install msgpack-rpc-python with integrated tornado from the local directory in which you cloned my fork, for example when you are currently in this directory: |
same error did anyone find a solution? Currently having the issue below :
But then when I upgrade tornado : |
Are there any plans to move towards a more recent version of Tornado?
Airsim uses msgpack-rpc-python (related issue), which is not compatible with Tornado >= v5 (deliberate decision here).
Unfortunately, the jupyter extension of VS Code needs Tornado >= v5. Are there any plans to update tornado to a more recent version? (Or are there not enough maintainers?)
Thx!
The text was updated successfully, but these errors were encountered: