-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] typescript compilation error when using v1.2.0 #2369
Comments
…ersion our `rush update --full` automation introduced a compilation error due to microsoft/ApplicationInsights-JS#2369 This PR pins its version to 1.1.2 until the issue is fixed.
…ersion our `rush update --full` automation introduced a compilation error due to microsoft/ApplicationInsights-JS#2369 This PR pins its version to 1.1.2 until the issue is fixed.
…ersion (#30233) our `rush update --full` automation introduced a compilation error due to microsoft/ApplicationInsights-JS#2369 This PR pins its version to 1.1.2 until the issue is fixed.
Hi, thanks for the information. We will make a new release which avoid the web package dependency. |
Note: that it will cause the definition of We had a previous issue where consumers did not want to have |
https://www.npmjs.com/package/@microsoft/applicationinsights-web-snippet version 1.2.1 is published now. This bug is fixed. |
Now that microsoft/ApplicationInsights-JS#2369 has been fixed. Revert "[EngSys] temporarily pin @microsoft/applicationinsights-web-snippet version (Azure#30233)" This reverts commit 1df8d78.
…0369) Now that microsoft/ApplicationInsights-JS#2369 has been fixed. Revert "[EngSys] temporarily pin @microsoft/applicationinsights-web-snippet version (#30233)" This reverts commit 1df8d78.
Description/Screenshot
One of our Azure SDK packages has a dependency on @microsoft/applicationinsights-web-snippet, after we upgrade from v1.1.2 to v1.2.0, we got this compilation error from TypeScript compiler. Looks that your type definition references @microsoft/applicationinsights-web, but it is only a dev dependency https://github.com/microsoft/ApplicationInsights-JS/blob/main/tools/applicationinsights-web-snippet/package.json#L35, so when users install @microsoft/applicationinsights-web-snippet they will not have @microsoft/applicationinsights-web
Steps to Reproduce
probably include @microsoft/applicationinsights-web-snippet 1.2.0 in a typescript project as a direct dependency then build the project
Expected behavior
No breaking changes between minor version increment.
Additional context
related Azure SDK for JS issue: Azure/azure-sdk-for-js#30224
The text was updated successfully, but these errors were encountered: