Roles Support in QuickPulse Java SDK #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rambhatt-msft
requested review from
heyams,
kryalama,
trask and
xiao-lix
as code owners
rambhatt-msft
changed the title
trask
reviewed
Feb 25, 2021
...java/com/microsoft/applicationinsights/internal/quickpulse/DefaultQuickPulseCoordinator.java
Outdated
Show resolved
Hide resolved
...java/com/microsoft/applicationinsights/internal/quickpulse/DefaultQuickPulseDataFetcher.java
Show resolved
Hide resolved
...java/com/microsoft/applicationinsights/internal/quickpulse/DefaultQuickPulseDataFetcher.java
Outdated
Show resolved
Hide resolved
...java/com/microsoft/applicationinsights/internal/quickpulse/DefaultQuickPulseDataFetcher.java
Outdated
Show resolved
Hide resolved
.../java/com/microsoft/applicationinsights/internal/quickpulse/DefaultQuickPulseDataSender.java
Outdated
Show resolved
Hide resolved
.../java/com/microsoft/applicationinsights/internal/quickpulse/DefaultQuickPulsePingSender.java
Show resolved
Hide resolved
.../java/com/microsoft/applicationinsights/internal/quickpulse/DefaultQuickPulsePingSender.java
Outdated
Show resolved
Hide resolved
.../java/com/microsoft/applicationinsights/internal/quickpulse/DefaultQuickPulsePingSender.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/microsoft/applicationinsights/internal/quickpulse/QuickPulseHeaderInfo.java
Outdated
Show resolved
Hide resolved
tokaplan
reviewed
Feb 25, 2021
...main/java/com/microsoft/applicationinsights/internal/quickpulse/QuickPulseNetworkHelper.java
Outdated
Show resolved
Hide resolved
tokaplan
reviewed
Feb 25, 2021
...main/java/com/microsoft/applicationinsights/internal/quickpulse/QuickPulseNetworkHelper.java
Outdated
Show resolved
Hide resolved
rambhatt-msft
commented
Feb 27, 2021
...java/com/microsoft/applicationinsights/internal/quickpulse/DefaultQuickPulseDataFetcher.java
Show resolved
Hide resolved
rambhatt-msft
commented
Feb 27, 2021
.../java/com/microsoft/applicationinsights/internal/quickpulse/DefaultQuickPulsePingSender.java
Show resolved
Hide resolved
trask
approved these changes
Feb 27, 2021
core/src/main/java/com/microsoft/applicationinsights/internal/quickpulse/QuickPulse.java
Outdated
Show resolved
Hide resolved
...main/java/com/microsoft/applicationinsights/internal/quickpulse/QuickPulseNetworkHelper.java
Outdated
Show resolved
Hide resolved
I am ready with the change. @tokaplan when you feel comfortable with it, we can merge. |
tokaplan
approved these changes
Mar 2, 2021
|
devops please run |
|
/AzurePipelines run |
|
No pipelines are associated with this pull request. |
|
/AzurePipelines run |
|
No pipelines are associated with this pull request. |
|
Thanks @rambhatt-msft! |
Thank for approving @trask 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix # .
For significant contributions please make sure you have completed the following items: