Add play framework preview instrumentation #1958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vazul
requested review from
heyams,
kryalama,
trask and
xiao-lix
as code owners
|
|
vazul
force-pushed
the
support_play_framework
branch
from
94b5377
to
97f5a83
Compare
heyams
reviewed
Nov 10, 2021
| @@ -52,7 +52,8 @@ | |||
| QUARTZ_DISABLED(21), // preview instrumentation, quartz is ON by default in OTEL | |||
| APACHE_CAMEL_DISABLED(22), // preview instrumentation, apache camel is ON by default in OTEL | |||
| AKKA_DISABLED(23), // preview instrumentation, akka is ON by default in OTEL | |||
| PROPAGATION_DISABLED(24); | |||
| PROPAGATION_DISABLED(24), | |||
| PLAY_DISABLED(25); // preview instrumentation, play is ON by default in OTEL | |||
|
LGTM @trask? |
trask
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add play framework support as preview instrumentation, as OTEL already has this instrumentation.