Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update otel to 1.19.0 #2596

Merged
merged 11 commits into from
Oct 20, 2022
Merged

Update otel to 1.19.0 #2596

merged 11 commits into from
Oct 20, 2022

Conversation

trask
Copy link
Member

@trask trask commented Oct 13, 2022

No description provided.

@jeanbisutti
Copy link
Member

@trask An idea for the following compilation issue?

/home/runner/work/ApplicationInsights-Java/ApplicationInsights-Java/agent/instrumentation/netty-4.1/src/main/java/io/opentelemetry/javaagent/instrumentation/netty/v4_1/appid/AppIdHandler.java:12: error: cannot find symbol
import io.opentelemetry.javaagent.instrumentation.netty.v4_1.AttributeKeys;
                                                            ^
  symbol:   class AttributeKeys
  location: package io.opentelemetry.javaagent.instrumentation.netty.v4_1

@trask trask marked this pull request as ready for review October 17, 2022 02:46
@jeanbisutti jeanbisutti mentioned this pull request Oct 17, 2022
Merged
@trask trask merged commit 980b744 into main Oct 20, 2022
@trask trask deleted the update-otel branch October 20, 2022 01:17
@trask trask mentioned this pull request Oct 20, 2022
Merged
trask added a commit that referenced this pull request Oct 20, 2022
@trask
Fix just merged code (#2607)
a77b14d 
I forgot to remove a test commit from #2596:
31a066d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanbisutti jeanbisutti jeanbisutti approved these changes

@heyams heyams Awaiting requested review from heyams heyams is a code owner

@johnoliver johnoliver Awaiting requested review from johnoliver johnoliver is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trask @jeanbisutti