Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable sampling override using thread.name #3285

Merged
merged 11 commits into from
Sep 18, 2023
Merged

Enable sampling override using thread.name #3285

merged 11 commits into from
Sep 18, 2023

Conversation

heyams
Copy link
Contributor

@heyams heyams commented Sep 11, 2023 •
edited
Loading

fix #3145

@heyams heyams force-pushed the heya/add-thread-attributes-to-sampler branch from ff59495 to c7e4088 Compare September 13, 2023 21:36
trask
trask reviewed Sep 15, 2023
View reviewed changes
...c/main/java/com/microsoft/applicationinsights/agent/internal/sampling/SamplingOverrides.java Outdated Show resolved Hide resolved
...c/main/java/com/microsoft/applicationinsights/agent/internal/sampling/SamplingOverrides.java Outdated Show resolved Hide resolved
...c/main/java/com/microsoft/applicationinsights/agent/internal/sampling/SamplingOverrides.java Outdated Show resolved Hide resolved
...c/main/java/com/microsoft/applicationinsights/agent/internal/sampling/SamplingOverrides.java Outdated Show resolved Hide resolved
...s/apps/SamplingOverrides/src/smokeTest/resources/applicationinsights-thread-id-and-name.json Outdated Show resolved Hide resolved
...s/apps/SamplingOverrides/src/smokeTest/resources/applicationinsights-thread-id-and-name.json Outdated Show resolved Hide resolved
@trask
Copy link
Member

trask commented Sep 15, 2023

@heyams I just realized thread.id is an AttributeKey<Long>. I believe we only support String and List<String> attribute types in sampling overries. Probably we can just remove thread.id support from this PR. I don't imagine that would be something someone would want to sample based on anyways.

@heyams heyams enabled auto-merge (squash) September 18, 2023 19:26
@heyams heyams merged commit 9235244 into main Sep 18, 2023
84 checks passed
@heyams heyams deleted the heya/add-thread-attributes-to-sampler branch September 18, 2023 19:40
@trask trask changed the title Enable sampling override using thread.id and thread.name Enable sampling override using thread.name Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanbisutti jeanbisutti jeanbisutti left review comments

@trask trask trask approved these changes

@ramthi ramthi Awaiting requested review from ramthi ramthi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is there a way to sample inProc dependency?
3 participants
@heyams @trask @jeanbisutti