Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor props #1523

Merged
merged 2 commits into from
Jan 2, 2020
Merged

refactor props #1523

merged 2 commits into from
Jan 2, 2020

Conversation

TimothyMothra
Copy link
Member

@TimothyMothra TimothyMothra commented Jan 2, 2020 •
edited
Loading

Remove analyzers from Test projects that are not passing. We may re-add these at a later date.

Fix Issue #1214 .

Changes

  • move all analyzer properties to a shared props file.
  • remove Analyzers from Test projects (not passing).
  • something is wrong with our published symbols. i've added the symbols to all nupkgs until we have more time to investigate.

Notes for reviewers:

  • We support comment build triggers
    • /AzurePipelines run will queue all builds
    • /AzurePipelines run <pipeline-name> will queue a specific build

@TimothyMothra
move all analyzer properties to a shared props file.
d914414 
Remove analyzers from Test projects that are not passing. We may re-add these at a later date.
@TimothyMothra
missed one
22d5e59
@TimothyMothra TimothyMothra merged commit 6548490 into develop Jan 2, 2020
@TimothyMothra TimothyMothra deleted the tilee/refactor_props branch January 2, 2020 23:49
@TimothyMothra
Copy link
Member Author

#1527

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TimothyMothra @reyang