Fail Firewall migration if there's no firewall (#2792)

microsoft · Oct 31, 2022 · 403804a · 403804a
1 parent 6034dc3
commit 403804a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/api_app/_version.py b/api_app/_version.py
@@ -1 +1 @@
-__version__ = "0.5.7"
+__version__ = "0.5.8"
diff --git a/api_app/db/migrations/shared_services.py b/api_app/db/migrations/shared_services.py
@@ -30,10 +30,13 @@ def checkMinFirewallVersion(self) -> bool:
         template_name = 'tre-shared-service-firewall'
         min_template_version = semantic_version.Version('0.4.0')
 
-        resource = self.query(query=f'SELECT * FROM c WHERE c.resourceType = "shared-service" \
+        resources = self.query(query=f'SELECT * FROM c WHERE c.resourceType = "shared-service" \
                                       AND c.templateName = "{template_name}" AND {IS_OPERATING_SHARED_SERVICE}')
 
-        template_version = semantic_version.Version(resource[0]["templateVersion"])
+        if not resources:
+            raise ValueError(f"Expecting to have an instance of Firewall (template name {template_name}) deployed in a successful TRE deployment")
+
+        template_version = semantic_version.Version(resources[0]["templateVersion"])
 
         if (template_version < min_template_version):
             raise ValueError(f"{template_name} deployed version ({template_version}) is below minimum ({min_template_version})!",