Skip to content

Commit

Permalink
MySQL Recreation Fix (#3994)
Browse files Browse the repository at this point in the history
* Update clean_validation_envs.yml

* update

* update BRANCH_LAST_ACTIVITY_IN_HOURS_FOR_STOP: 8

* update charset and collation

* update chnagelog

* add in lifecylce rule for charset and collation

* update changelog

* update clean env yaml
  • Loading branch information
tim-allen-ck committed Jun 21, 2024
1 parent 1ffb09b commit 59d006a
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ BUG FIXES:
* Add workaround to avoid name clashes for storage accounts([#3863](https://github.com/microsoft/AzureTRE/pull/3858))
* Resource processor fails to deploy first workspace on fresh TRE deployment ([#3950](https://github.com/microsoft/AzureTRE/issues/3950))
* Dependency and Vulnerability updates
* Add lifecycle rule to MySQL resources to stop them recreating on `update` ([#3993](https://github.com/microsoft/AzureTRE/issues/3993))

COMPONENTS:

Expand Down
2 changes: 1 addition & 1 deletion templates/workspace_services/gitea/porter.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
schemaVersion: 1.0.0
name: tre-workspace-service-gitea
version: 1.0.1
version: 1.0.2
description: "A Gitea workspace service"
dockerfile: Dockerfile.tmpl
registry: azuretre
Expand Down
2 changes: 2 additions & 0 deletions templates/workspace_services/gitea/terraform/mysql.tf
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ resource "azurerm_mysql_flexible_database" "gitea" {
server_name = azurerm_mysql_flexible_server.gitea.name
charset = "utf8"
collation = "utf8_unicode_ci"

lifecycle { ignore_changes = [charset, collation] }
}

moved {
Expand Down
2 changes: 1 addition & 1 deletion templates/workspace_services/mysql/porter.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
schemaVersion: 1.0.0
name: tre-workspace-service-mysql
version: 1.0.1
version: 1.0.2
description: "A MySQL workspace service"
registry: azuretre
dockerfile: Dockerfile.tmpl
Expand Down
2 changes: 2 additions & 0 deletions templates/workspace_services/mysql/terraform/mysql.tf
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ resource "azurerm_mysql_flexible_database" "db" {
server_name = azurerm_mysql_flexible_server.mysql.name
charset = "utf8"
collation = "utf8_unicode_ci"

lifecycle { ignore_changes = [charset, collation] }
}

resource "azurerm_private_endpoint" "mysql_private_endpoint" {
Expand Down

0 comments on commit 59d006a

Please sign in to comment.