Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guacamole configures firewall with deployment pipeline #2206

Closed
3 tasks
tamirkamara opened this issue Jul 6, 2022 · 1 comment · Fixed by #2371
Closed
3 tasks

Guacamole configures firewall with deployment pipeline #2206

tamirkamara opened this issue Jul 6, 2022 · 1 comment · Fixed by #2371
Assignees
Labels
bundles Creating and deploying bundles/templates story Stories are the smallest unit of work to be done for a project.

Comments

@tamirkamara
Copy link
Collaborator

Description

As a TRE Developer
I want to configure required firewall rules with the deployment pipeline
So that firewall rules will be managed centrally in the shared service

Acceptance criteria

  • get_firewall_priorities.sh is removed
  • Required rules are present in firewall on azure and in state of the firewall shared service
  • Both install and uninstall work
@tamirkamara tamirkamara added bundles Creating and deploying bundles/templates story Stories are the smallest unit of work to be done for a project. labels Jul 6, 2022
@tamirkamara tamirkamara added this to the Release 0.4 milestone Jul 6, 2022
@tamirkamara
Copy link
Collaborator Author

tamirkamara commented Jul 10, 2022

Not sure how to do this for cases where the rule name isn't fixed like for this workspace service:
image

"stepTitle": "Add guacamole network rule to firewall",
"resourceTemplateName": "tre-shared-service-firewall",
"resourceType": "shared-service",
"resourceAction": "upgrade",
"properties": [
  {
    "name": "network_rule_collections",
    "type": "array",
    "arraySubstitutionAction": "replace",
    "arrayMatchField": "name",
    "value": {
      "name": "nrc-web_app_subnet_nexus_v2",
      "action": "Allow"
      ...
      }
  }
]

@damoodamoo any suggestion?

@tamirkamara tamirkamara added the blocked Cannot progress at present label Jul 10, 2022
@tamirkamara tamirkamara removed the blocked Cannot progress at present label Jul 18, 2022
@tamirkamara tamirkamara self-assigned this Jul 18, 2022
@tamirkamara tamirkamara added blocked Cannot progress at present and removed blocked Cannot progress at present labels Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bundles Creating and deploying bundles/templates story Stories are the smallest unit of work to be done for a project.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant