-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guacamole updates firewall with deployment pipeline #2371
Guacamole updates firewall with deployment pipeline #2371
Conversation
/test-extended |
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2753298341 (with refid (in response to this comment from @tamirkamara) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/test-extended |
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2754647476 (with refid (in response to this comment from @tamirkamara) |
/test-destroy-env |
Destroying PR test environment (RG: rg-tred476a9dd)... (run: https://github.com/microsoft/AzureTRE/actions/runs/2755545978) |
Destroying branch test environment (RG: rg-treeeb73ede)... (run: https://github.com/microsoft/AzureTRE/actions/runs/2755545978) |
Branch test environment destroy complete (RG: rg-treeeb73ede) |
PR test environment destroy complete (RG: rg-tred476a9dd) |
/test-extended |
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2755743200 (with refid (in response to this comment from @tamirkamara) |
@tamirkamara given the firewall is a shared service, how do I get these changes into an existing TRE deployment? Thanks. |
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2768506910 (with refid (in response to this comment from @tamirkamara) |
@marrobi unfortunately this is a manual process. I added a note in the changelog. |
Resolves #2206
What is being addressed
Guacamole workspace service configured its firewall rules by using a script which is now obsolete as we have a deployment pipeline that should be used.
How is this addressed