-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration to check firewall meets min version #2386
Conversation
Unit Test Results466 tests +448 464 ✔️ +446 11s ⏱️ -1s Results for commit b957e91. ± Comparison against base commit c05a4b5. This pull request removes 18 and adds 466 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2780298202 (with refid (in response to this comment from @tamirkamara) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Made a small edit, take it or leave it.
Co-authored-by: Marcus Robinson <marrobi@microsoft.com>
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2781250177 (with refid (in response to this comment from @tamirkamara) |
@tamirkamara so hit this now merged.
|
What is being addressed
Following #2371, we decided to add a migration check to validate that the deployed firewall version meets a minimum requirement.