Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make db-migrate is not working #3121

Closed
dusan-ilic-mhra opened this issue Jan 25, 2023 · 4 comments · Fixed by #3152
Closed

make db-migrate is not working #3121

dusan-ilic-mhra opened this issue Jan 25, 2023 · 4 comments · Fixed by #3152
Assignees
Labels
bug Something isn't working

Comments

@dusan-ilic-mhra
Copy link
Contributor

Describe the bug
We upgraded TRE CORE to v0.7.0 and in the release notes we saw this:

0.7.0
BREAKING CHANGES & MIGRATIONS:

The airlock request object has changed. Make sure you have ran the db migration step after deploying the new API image and UI (which runs automatically in make all/make tre-deploy but can be manually invoked with make db-migrate) so that existing requests in your DB are migrated to the new model.

We executed make db-migrate command and we got this output:
image

But, still we have an issue when we want to review Airlock requests:

image

Steps to reproduce

  1. Run make db-migrate on TEST environment
  2. Log in to swagger for workspace and run GET /api/workspaces/{workspace_id}/requests from the airlock section
@dusan-ilic-mhra dusan-ilic-mhra added the bug Something isn't working label Jan 25, 2023
@tamirkamara tamirkamara self-assigned this Jan 26, 2023
@tamirkamara
Copy link
Collaborator

@dusan-ilic-mhra is the problem with pre-exiting requests that were opened before the upgrade?
Or, have you opened a new request after the upgrade and fail on it?

@dusan-ilic-mhra
Copy link
Contributor Author

dusan-ilic-mhra commented Jan 26, 2023

@tamirkamara It's the problem with pre-existing requests that were opened before the upgrade.
And, as we can see it's only related to approved and rejected states.

@tamirkamara
Copy link
Collaborator

@dusan-ilic-mhra Which TRE OSS version have these been created in?

@dusan-ilic-mhra
Copy link
Contributor Author

@tamirkamara 0.4.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants