-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate reviewDecision of Airlock Reviews #3152
Migrate reviewDecision of Airlock Reviews #3152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…com/yuvalyaron/AzureTRE into 3121-migrate-airlock-reviewdecision
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4053761165 (with refid (in response to this comment from @yuvalyaron) |
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4053804149 (with refid (in response to this comment from @yuvalyaron) |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4053804149 (with refid (in response to this comment from @yuvalyaron) |
Resolves #3121
What is being addressed
Airlock reviews used to have one of these values:
approval_in_progress
andrejection_in_progress
.But since #2670 , instead of using these values, we use
approved
andrejected
,This causes API type errors when trying to GET requests that have been created with older TRE versions, as these contain the older values.
How is this addressed