Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI airlock review requests #2670

Merged
merged 6 commits into from
Oct 3, 2022
Merged

Conversation

jjgriff93
Copy link
Collaborator

@jjgriff93 jjgriff93 commented Oct 1, 2022

Resolves #2352

What is being addressed

This adds the ability to create an airlock review in the UI as well as view reviews on a request.

How is this addressed

  • Added submit review api method
  • Ui display for approval/rejection
  • Fixed API incorrectly labelling review decisions as request statuses
  • Support for local debugging of UI alongside local API (CORS)
  • Fix for UX App Registration not allowing local UI debugging out of the box

image

image

@github-actions
Copy link

github-actions bot commented Oct 1, 2022

Unit Test Results

512 tests   512 ✔️  18s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit c366e8b.

♻️ This comment has been updated with latest results.

Copy link
Member

@damoodamoo damoodamoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work - i've had a side branch with the CORS stuff + local debugging too, but never managed to actually PR it, great to get it in.

@jjgriff93
Copy link
Collaborator Author

/test

@github-actions
Copy link

github-actions bot commented Oct 3, 2022

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3174847109 (with refid 04ab6f09)

(in response to this comment from @jjgriff93)

@jjgriff93 jjgriff93 enabled auto-merge (squash) October 3, 2022 15:49
@jjgriff93
Copy link
Collaborator Author

/test

@github-actions
Copy link

github-actions bot commented Oct 3, 2022

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3175546679 (with refid 04ab6f09)

(in response to this comment from @jjgriff93)

@jjgriff93 jjgriff93 merged commit 80a6ae2 into main Oct 3, 2022
@jjgriff93 jjgriff93 deleted the jjgriff93/2352-ui-airlock-review_requests branch October 3, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Airlock UI: Review a Request
3 participants