Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide ability to copy URL to access an internally accessible resource. #3122

Closed
marrobi opened this issue Jan 25, 2023 · 3 comments · Fixed by #3420
Closed

Provide ability to copy URL to access an internally accessible resource. #3122

marrobi opened this issue Jan 25, 2023 · 3 comments · Fixed by #3420
Assignees
Labels
bug Something isn't working ui TRE UI

Comments

@marrobi
Copy link
Member

marrobi commented Jan 25, 2023

As a researcher I can click on a connect button to access a TRE resource. If a resource is only available internally I cannot click connect. I do however need to be able to copy the URI. I cannot do this at present. The AML service shows a button that doesn't work, others there is no button.

Reproduce:

  • Workspace with VMs and AML with no public access
  • Login as Workspace Researcher (not owner)
  • Access AML

Notes:
At present we have connection_uri and internal_connection_uri. We also have is_exposed_externally. Using a combination of these fields the appropriate behaviour should occur. If accessible, a button to click, if not a button to copy URI to the clipboard.

@marrobi marrobi added bug Something isn't working ui TRE UI labels Jan 25, 2023
@guybartal
Copy link
Contributor

remove internal_connection_uri and always use connection_uri, and in the UI render the button according to the is_exposed_externally input parameter (copy button the connection_uri to clipboard /link).

@guybartal
Copy link
Contributor

guybartal commented Feb 6, 2023

@anatbal anatbal self-assigned this Feb 22, 2023
@marrobi
Copy link
Member Author

marrobi commented Apr 3, 2023

@anatbal are you planning to work on this/did you do any work/design?

It's causing confusion for some customers, and keen to get a quick fix of some sort in.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui TRE UI
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants