Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide ability to copy URL to access an internally accessible resource #3420

Merged
merged 15 commits into from
Apr 17, 2023
Merged

Provide ability to copy URL to access an internally accessible resource #3420

merged 15 commits into from
Apr 17, 2023

Conversation

anatbal
Copy link
Collaborator

@anatbal anatbal commented Apr 4, 2023 •
edited
Loading

Resolves #3122

What is being addressed

The connect button for the ws service and the user resource will now pop up a window referencing to clipboard when the guacamole is not exposed externally.
image
image

@github-actions
Copy link

github-actions bot commented Apr 4, 2023 •
edited
Loading

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 7d14ed4.

♻️ This comment has been updated with latest results.

@anatbal anatbal changed the title Provide ability to copy URL to access an internally accessible resource. Provide ability to copy URL to access an internally accessible resource Apr 4, 2023
damoodamoo
damoodamoo approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@damoodamoo damoodamoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like it!

@anatbal
Copy link
Collaborator Author

anatbal commented Apr 17, 2023

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4722314741 (with refid 242366ac)

(in response to this comment from @anatbal)

2 similar comments
@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4722314741 (with refid 242366ac)

(in response to this comment from @anatbal)

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4722314741 (with refid 242366ac)

(in response to this comment from @anatbal)

@anatbal anatbal enabled auto-merge (squash) April 17, 2023 17:58
@anatbal
Copy link
Collaborator Author

anatbal commented Apr 17, 2023

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4724280616 (with refid 242366ac)

(in response to this comment from @anatbal)

1 similar comment
@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4724280616 (with refid 242366ac)

(in response to this comment from @anatbal)

@anatbal anatbal merged commit de5f662 into main Apr 17, 2023
@anatbal anatbal deleted the feature/ui-copy-when-wsv-not-external branch April 17, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damoodamoo damoodamoo damoodamoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide ability to copy URL to access an internally accessible resource.
2 participants
@anatbal @damoodamoo