Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable workspace AppInsight's private endpoint #2543

Merged
merged 3 commits into from
Sep 4, 2022

Conversation

tamirkamara
Copy link
Collaborator

@tamirkamara tamirkamara commented Sep 4, 2022

What is being addressed

Due to many failures when creating the workspace's private endpoint for app insights, we need to disable it for now while our support case / PG conversation is still going.

In addition this PR disables the Terraform checkpoint mechanism as that doesn't work in an airgap environment. The error is comes to solve is Terraform unable to query provider/plugin versions.

Ongoing parent issue: #2357

@github-actions
Copy link

github-actions bot commented Sep 4, 2022

Unit Test Results

0 tests   - 16   0 ✔️  - 16   0s ⏱️ -6s
0 suites  -   1   0 💤 ±  0 
0 files    -   1   0 ±  0 

Results for commit d53edaa. ± Comparison against base commit f6f9650.

♻️ This comment has been updated with latest results.

@tamirkamara
Copy link
Collaborator Author

/test

@github-actions
Copy link

github-actions bot commented Sep 4, 2022

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2987808270 (with refid 7d59b4e4)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

github-actions bot commented Sep 4, 2022

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2988157172 (with refid 7d59b4e4)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara enabled auto-merge (squash) September 4, 2022 14:28
@tamirkamara tamirkamara merged commit e51cc6e into main Sep 4, 2022
@tamirkamara tamirkamara deleted the tamirkamara/disable-workspace-appinsights-pe branch September 4, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants