Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Nexus V1 #2580

Merged
merged 10 commits into from
Sep 11, 2022
Merged

Remove Nexus V1 #2580

merged 10 commits into from
Sep 11, 2022

Conversation

tamirkamara
Copy link
Collaborator

Resolves #1981

What is being addressed

Nexus V2 was introduced a few months ago and it's time to remove all support for V1.

How is this addressed

  • Delete Nexus V1 bundle
  • Delete other bundle's parameters referencing V1
  • Update documentation

@github-actions
Copy link

github-actions bot commented Sep 11, 2022

Unit Test Results

499 tests  +497   497 ✔️ +497   11s ⏱️ +10s
    1 suites ±    0       2 💤 +    2 
    1 files   ±    0       0  -     2 

Results for commit 5a720c2. ± Comparison against base commit 86c1734.

This pull request removes 2 and adds 499 tests. Note that renamed tests count towards both.
test_airlock ‑ test_airlock_import_flow
test_workspace_services ‑ test_create_guacamole_service_into_base_workspace
tests_ma.test_api.test_errors.test_422_error ‑ test_frw_validation_error_format
tests_ma.test_api.test_errors.test_error ‑ test_frw_validation_error_format
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireAirlockManagerRights ‑ test_post_create_airlock_review_approves_airlock_request_returns_200
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireAirlockManagerRights ‑ test_post_create_airlock_review_input_is_malformed_returns_400
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireAirlockManagerRights ‑ test_post_create_airlock_review_with_event_grid_not_responding_returns_503
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireAirlockManagerRights ‑ test_post_create_airlock_review_with_illegal_status_change_returns_400
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireOwnerOrResearcherRights ‑ test_get_airlock_container_link_cancelled_request_returns_400
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireOwnerOrResearcherRights ‑ test_get_airlock_container_link_in_progress_request_returns_400
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireOwnerOrResearcherRights ‑ test_get_airlock_container_link_no_airlock_request_found_returns_404
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireOwnerOrResearcherRights ‑ test_get_airlock_container_link_no_workspace_request_found_returns_404
…

♻️ This comment has been updated with latest results.

@tamirkamara tamirkamara marked this pull request as ready for review September 11, 2022 05:59
@tamirkamara
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3030719472 (with refid 2ff25441)

(in response to this comment from @tamirkamara)

CHANGELOG.md Outdated Show resolved Hide resolved
tamirkamara and others added 2 commits September 11, 2022 07:02
Co-authored-by: Elad Iwanir <13205761+eladiw@users.noreply.github.com>
@tamirkamara
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3030897858 (with refid 2ff25441)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara merged commit fd525e0 into main Sep 11, 2022
@tamirkamara tamirkamara deleted the tamirkamara/1981-remove-nexus-v1 branch September 11, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove App-Service based (V1) Nexus
2 participants