Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support template version patching #2671

Conversation

guybartal
Copy link
Contributor

@guybartal guybartal commented Oct 1, 2022

Resolves #1744

What is being addressed

Support updating template version when patching resources

How is this addressed

@github-actions
Copy link

github-actions bot commented Oct 1, 2022

Unit Test Results

512 tests  +507   512 ✔️ +508   13s ⏱️ - 2h 23m 39s
    1 suites ±    0       0 💤 ±    0 
    1 files   ±    0       0  -     1 

Results for commit 7efa18d. ± Comparison against base commit 0df13fd.

This pull request removes 5 and adds 512 tests. Note that renamed tests count towards both.
test_airlock ‑ test_airlock_import_flow
test_shared_services ‑ test_create_shared_service[tre-shared-service-gitea]
test_shared_services ‑ test_patch_firewall
test_workspace_services ‑ test_create_guacamole_service_into_aad_workspace
test_workspace_services ‑ test_create_guacamole_service_into_base_workspace
tests_ma.test_api.test_errors.test_422_error ‑ test_frw_validation_error_format
tests_ma.test_api.test_errors.test_error ‑ test_frw_validation_error_format
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireAirlockManagerRights ‑ test_post_create_airlock_review_approves_airlock_request_returns_200
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireAirlockManagerRights ‑ test_post_create_airlock_review_input_is_malformed_returns_400
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireAirlockManagerRights ‑ test_post_create_airlock_review_with_event_grid_not_responding_returns_503
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireAirlockManagerRights ‑ test_post_create_airlock_review_with_illegal_status_change_returns_400
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireOwnerOrResearcherRights ‑ test_get_airlock_container_link_cancelled_request_returns_400
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireOwnerOrResearcherRights ‑ test_get_airlock_container_link_in_progress_request_returns_400
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireOwnerOrResearcherRights ‑ test_get_airlock_container_link_no_airlock_request_found_returns_404
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireOwnerOrResearcherRights ‑ test_get_airlock_container_link_no_workspace_request_found_returns_404
…

♻️ This comment has been updated with latest results.

@guybartal
Copy link
Contributor Author

/test-extended

@github-actions
Copy link

github-actions bot commented Oct 1, 2022

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3166225787 (with refid bd037eb1)

(in response to this comment from @guybartal)

Copy link
Collaborator

@tamirkamara tamirkamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but will another person take a look too.

@marrobi marrobi marked this pull request as draft October 3, 2022 08:11
auto-merge was automatically disabled October 3, 2022 08:11

Pull request was converted to draft

@marrobi
Copy link
Member

marrobi commented Nov 2, 2022

Discussed again and @guybartal going to create a design to enable an upgradable from approach as per #1744 (comment)

@guybartal guybartal closed this Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants