Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cran support in nexus #2694

Merged
merged 28 commits into from
Oct 18, 2022
Merged

Conversation

JaimieWi
Copy link
Contributor

@JaimieWi JaimieWi commented Oct 3, 2022

What is being addressed

Add support for R and R studio to install packages through Nexus.

Three steps required:

  1. Add https://cran.r-project.org/ to Nexus
  2. Configure the Rprofile.site file on the VMs to use Nexus as the default repo
  3. Adding the two required URLs to the Firewall configuration: https://cran.r-project.org/, https://cloud.r-project.org/

Windows then required an additional step due to cert revocation. Therefore, port 80 has been opened for the workspace NSGs and a new set of Target FQDNs added to the firewall. These were identified by looking through the firewall logs and determining which destinations were required.

How is this addressed

  1. Create cran_proxy_support.json to add r to Nexus.
  2. Edit templates/shared_services/sonatype-nexus-vm/terraform/firewall.tf and templates/shared_services/sonatype-nexus-vm/terraform/locals.tf to add windows firewall rule for CRL.
  3. Edit templates/workspaces/base/terraform/network/security.tf to open port 80 on workspace nsg, set to be priority 101.
  4. Edit vm config files to set default repo to be Nexus

@github-actions github-actions bot added the external PR from an external contributor label Oct 3, 2022
@github-actions
Copy link

github-actions bot commented Oct 3, 2022

Unit Test Results

0 tests   - 17   0 ✔️  - 17   0s ⏱️ -6s
0 suites  -   1   0 💤 ±  0 
0 files    -   1   0 ±  0 

Results for commit f7336e4. ± Comparison against base commit 32533a6.

♻️ This comment has been updated with latest results.

@tamirkamara tamirkamara changed the title Jaimie wi/cran support cran support in nexus Oct 3, 2022
@stuartleeks stuartleeks marked this pull request as draft October 6, 2022 08:33
@JaimieWi JaimieWi marked this pull request as ready for review October 7, 2022 13:08
@JaimieWi JaimieWi marked this pull request as draft October 7, 2022 16:10
@JaimieWi JaimieWi marked this pull request as ready for review October 11, 2022 16:16
@damoodamoo
Copy link
Member

/test-shared-services 2479289

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running shared service tests: https://github.com/microsoft/AzureTRE/actions/runs/3271876268 (with refid af1d1a27)

(in response to this comment from @damoodamoo)

Copy link
Member

@damoodamoo damoodamoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woooop! LGTM :)

@damoodamoo damoodamoo enabled auto-merge (squash) October 18, 2022 13:09
@damoodamoo
Copy link
Member

/test-force-approve

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit f7336e4)

(in response to this comment from @damoodamoo)

@damoodamoo damoodamoo merged commit 8b47280 into microsoft:main Oct 18, 2022
@JaimieWi JaimieWi deleted the JaimieWi/cran_support branch October 18, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external PR from an external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants