Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRE CLI in devcontainer #2757

Merged
merged 3 commits into from
Oct 19, 2022
Merged

TRE CLI in devcontainer #2757

merged 3 commits into from
Oct 19, 2022

Conversation

tamirkamara
Copy link
Collaborator

What is being addressed

We currently install the TRE CLI on every "create" of the container. In the CI this method creates some noise as every time we execute a container command we also need to install the CLI.

How is this addressed

  • Install the TRE CLI inside the devcontainer image, much like we do for most other tools used.

@github-actions
Copy link

github-actions bot commented Oct 19, 2022

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 7e00afa.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@stuartleeks stuartleeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments, but otherwise LGTM

.devcontainer/Dockerfile Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Stuart Leeks <stuartle@microsoft.com>
@tamirkamara tamirkamara marked this pull request as ready for review October 19, 2022 11:50
@tamirkamara
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3281332836 (with refid 5ad8771e)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara merged commit 619b733 into main Oct 19, 2022
@tamirkamara tamirkamara deleted the tamirkamara/tre-cli-in-image branch October 19, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants