Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: redesign resource cards #2846

Merged
merged 16 commits into from
Nov 9, 2022
Merged

Conversation

jjgriff93
Copy link
Collaborator

@jjgriff93 jjgriff93 commented Nov 9, 2022

Resolves #2242
Resolves #2321
Resolves #2661

What is being addressed

I've re-designed the UI resource cards to bring them inline with the Figma designs. As part of this I've added a disabled state badge to show when a resource is disabled, added the resource Id to the info callout, re-worked the costs display to show currency symbols and also added health information to the footer callout.

image

image

image

image

image

image

image

How is this addressed

  • Changed costs display to use badge and Intel.NumberFormat for locale formatting of currencies
  • Re-designed card CSS
  • Re-designed status badge and added disabled state
  • Added health endpoint info to footer callout
  • Added resource id to resource info
  • Converted resource callouts to popovers
  • Updated CHANGELOG.md

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 4a15fcc.

♻️ This comment has been updated with latest results.

Copy link
Member

@damoodamoo damoodamoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it!

@jjgriff93 jjgriff93 enabled auto-merge (squash) November 9, 2022 13:16
@jjgriff93
Copy link
Collaborator Author

/test-force-approve

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 4a15fcc)

(in response to this comment from @jjgriff93)

@jjgriff93 jjgriff93 merged commit 37b0c6b into main Nov 9, 2022
@jjgriff93 jjgriff93 deleted the jjgriff93/ui-redesign-resource-cards branch November 9, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants