Fix get shared service by template name to filter by active service only #2947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybartal
changed the title
guybartal
changed the title
tanya-borisova
approved these changes
Dec 6, 2022
|
/test |
|
🤖 pr-bot 🤖 (in response to this comment from @guybartal) |
|
/test |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3630441691 (with refid (in response to this comment from @guybartal) |
tamirkamara
reviewed
Dec 6, 2022
guybartal
changed the title
|
/test |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3636993045 (with refid (in response to this comment from @guybartal) |
tanya-borisova
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2910
What is being addressed
When fetching shared service by template name it may return more than single result when there are inactive or deleted shared services, this change fixes the filter to return only operating shared service by template name.
How is this addressed
deploymentStatus != "deleted" and deploymentStatus != "deployment-failed"