Lint TRE cost tags #3061
Merged
Lint TRE cost tags #3061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamirkamara
force-pushed
the
tamirkamara/superlint-tre-cost-tags
branch
from
833fa47
to
9cbd83f
Compare
guybartal
approved these changes
Jan 10, 2023
tamirkamara
force-pushed
the
tamirkamara/superlint-tre-cost-tags
branch
from
9cbd83f
to
22bf27d
Compare
|
/test-force-approve |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 22bf27d) (in response to this comment from @tamirkamara) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is being addressed
We have been checking that each TRE resource has the tre_id tag as that is the common one between all entities (like workspace, workspace service, etc.).
Ideally we should lint each TRE level for its respective tag requirements.
How is this addressed
localdefinition)