Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align 'Airlock Get Container URL' permissions with 'Create Airlock Request's permissions #3208

Conversation

yuvalyaron
Copy link
Contributor

@yuvalyaron yuvalyaron commented Feb 8, 2023

Resolves #3187

What is being addressed

Verified that every role that is able to create an Airlock request is also able to upload a file to the request.

How is this addressed

  • Added Workspace Owner to the roles that can access the container link when the status is not in_review
  • Added tests to verify that the roles are aligned

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

Unit Test Results

559 tests   559 ✔️  13s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit 620547f.

♻️ This comment has been updated with latest results.

@yuvalyaron yuvalyaron marked this pull request as ready for review February 8, 2023 13:26
Copy link
Contributor

@LizaShak LizaShak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@yuvalyaron
Copy link
Contributor Author

/test

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4125164688 (with refid 2d87f382)

(in response to this comment from @yuvalyaron)

@yuvalyaron yuvalyaron enabled auto-merge (squash) February 8, 2023 14:33
@yuvalyaron
Copy link
Contributor Author

/test

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4125836051 (with refid 2d87f382)

(in response to this comment from @yuvalyaron)

@yuvalyaron yuvalyaron merged commit 06ec5a8 into microsoft:main Feb 8, 2023
@yuvalyaron yuvalyaron deleted the 3187-align-airlock-get-container-url-permissions branch February 8, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align the permissions of Airlock GET container URL
2 participants