Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move duplicated logic to scripts #3371

Merged
merged 9 commits into from
Mar 28, 2023
Merged

Move duplicated logic to scripts #3371

merged 9 commits into from
Mar 28, 2023

Conversation

yuvalyaron
Copy link
Contributor

@yuvalyaron yuvalyaron commented Mar 27, 2023 •
edited
Loading

Improves #3299

What is being addressed

Moved duplicated logic to shared scripts

@yuvalyaron yuvalyaron marked this pull request as ready for review March 27, 2023 13:45
@yuvalyaron yuvalyaron marked this pull request as draft March 27, 2023 13:45
@github-actions
Copy link

github-actions bot commented Mar 27, 2023 •
edited
Loading

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 8b3d40c.

♻️ This comment has been updated with latest results.

@yuvalyaron yuvalyaron changed the title Move common logic to scripts Move duplicated logic to scripts Mar 27, 2023
@yuvalyaron yuvalyaron temporarily deployed to CICD March 27, 2023 13:59 — with GitHub Actions Inactive
@yuvalyaron yuvalyaron temporarily deployed to CICD March 27, 2023 14:02 — with GitHub Actions Inactive
@yuvalyaron yuvalyaron temporarily deployed to CICD March 27, 2023 14:02 — with GitHub Actions Inactive
@yuvalyaron yuvalyaron temporarily deployed to CICD March 27, 2023 14:02 — with GitHub Actions Inactive
@yuvalyaron yuvalyaron temporarily deployed to CICD March 27, 2023 14:02 — with GitHub Actions Inactive
@yuvalyaron yuvalyaron temporarily deployed to CICD March 27, 2023 14:02 — with GitHub Actions Inactive
@yuvalyaron yuvalyaron temporarily deployed to CICD March 27, 2023 14:02 — with GitHub Actions Inactive
@yuvalyaron yuvalyaron temporarily deployed to CICD March 27, 2023 14:02 — with GitHub Actions Inactive
@yuvalyaron yuvalyaron temporarily deployed to CICD March 27, 2023 14:02 — with GitHub Actions Inactive
@yuvalyaron yuvalyaron temporarily deployed to CICD March 27, 2023 14:02 — with GitHub Actions Inactive
@yuvalyaron yuvalyaron temporarily deployed to CICD March 27, 2023 14:02 — with GitHub Actions Inactive
@yuvalyaron yuvalyaron temporarily deployed to CICD March 27, 2023 14:02 — with GitHub Actions Inactive
@yuvalyaron yuvalyaron temporarily deployed to CICD March 27, 2023 14:02 — with GitHub Actions Inactive
@yuvalyaron yuvalyaron temporarily deployed to CICD March 27, 2023 14:02 — with GitHub Actions Inactive
@yuvalyaron yuvalyaron temporarily deployed to CICD March 27, 2023 14:02 — with GitHub Actions Inactive
@yuvalyaron yuvalyaron temporarily deployed to CICD March 27, 2023 14:02 — with GitHub Actions Inactive
@yuvalyaron yuvalyaron temporarily deployed to CICD March 27, 2023 14:02 — with GitHub Actions Inactive
@yuvalyaron yuvalyaron temporarily deployed to CICD March 27, 2023 14:02 — with GitHub Actions Inactive
@yuvalyaron yuvalyaron temporarily deployed to CICD March 27, 2023 14:02 — with GitHub Actions Inactive
@yuvalyaron yuvalyaron temporarily deployed to CICD March 27, 2023 14:02 — with GitHub Actions Inactive
@yuvalyaron yuvalyaron temporarily deployed to CICD March 27, 2023 14:02 — with GitHub Actions Inactive
@yuvalyaron yuvalyaron temporarily deployed to CICD March 27, 2023 14:02 — with GitHub Actions Inactive
@yuvalyaron yuvalyaron temporarily deployed to CICD March 27, 2023 14:13 — with GitHub Actions Inactive
@yuvalyaron yuvalyaron temporarily deployed to CICD March 27, 2023 14:13 — with GitHub Actions Inactive
@yuvalyaron yuvalyaron temporarily deployed to CICD March 27, 2023 14:13 — with GitHub Actions Inactive
@yuvalyaron yuvalyaron temporarily deployed to CICD March 27, 2023 14:13 — with GitHub Actions Inactive
@yuvalyaron yuvalyaron temporarily deployed to CICD March 27, 2023 14:13 — with GitHub Actions Inactive
@yuvalyaron yuvalyaron temporarily deployed to CICD March 27, 2023 14:13 — with GitHub Actions Inactive
@yuvalyaron yuvalyaron temporarily deployed to CICD March 27, 2023 14:13 — with GitHub Actions Inactive
@yuvalyaron yuvalyaron temporarily deployed to CICD March 27, 2023 14:13 — with GitHub Actions Inactive
@yuvalyaron yuvalyaron temporarily deployed to CICD March 27, 2023 14:13 — with GitHub Actions Inactive
@yuvalyaron yuvalyaron temporarily deployed to CICD March 27, 2023 14:16 — with GitHub Actions Inactive
@yuvalyaron yuvalyaron temporarily deployed to CICD March 27, 2023 14:16 — with GitHub Actions Inactive
@yuvalyaron yuvalyaron temporarily deployed to CICD March 27, 2023 14:16 — with GitHub Actions Inactive
@yuvalyaron yuvalyaron temporarily deployed to CICD March 27, 2023 14:16 — with GitHub Actions Inactive
@yuvalyaron yuvalyaron temporarily deployed to CICD March 27, 2023 14:16 — with GitHub Actions Inactive
@yuvalyaron yuvalyaron temporarily deployed to CICD March 27, 2023 14:18 — with GitHub Actions Inactive
tamirkamara
tamirkamara approved these changes Mar 27, 2023
View reviewed changes
devops/scripts/construct_tre_url.sh Outdated Show resolved Hide resolved
devops/scripts/convert_azure_env_to_arm_env.sh Outdated Show resolved Hide resolved
devops/scripts/load_and_validate_env.sh Outdated Show resolved Hide resolved
devops/scripts/load_and_validate_env.sh Outdated Show resolved Hide resolved
devops/scripts/load_and_validate_env.sh Show resolved Hide resolved
yuvalyaron and others added 5 commits March 27, 2023 14:50
@yuvalyaron
remove bash options
f7a1e5d
@yuvalyaron @tamirkamara
Update devops/scripts/load_and_validate_env.sh
0fc2c29 
Co-authored-by: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
@yuvalyaron @tamirkamara
Update devops/scripts/load_and_validate_env.sh
7fc0117 
Co-authored-by: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
@yuvalyaron
Merge branch 'feature/gov-cloud' of https://github.com/microsoft/Azur…
04c89cf 
…eTRE into 3299-move-common-logic-to-scripts
@yuvalyaron
Merge branch '3299-move-common-logic-to-scripts' of https://github.co…
8b3d40c 
…m/microsoft/AzureTRE into 3299-move-common-logic-to-scripts
@yuvalyaron yuvalyaron marked this pull request as ready for review March 28, 2023 07:25
@yuvalyaron yuvalyaron enabled auto-merge (squash) March 28, 2023 07:26
@yuvalyaron yuvalyaron merged commit a0a2334 into feature/gov-cloud Mar 28, 2023
@yuvalyaron yuvalyaron deleted the 3299-move-common-logic-to-scripts branch March 28, 2023 07:29
LizaShak added a commit that referenced this pull request Apr 2, 2023
@yuvalyaron @LizaShak @tamirkamara
Move duplicated logic to scripts (#3371)
923272c 
* move construction of tre_url to script and source it

* Use Azure environment in local deployment

* move conversion of azure_env to arm_env to script and source it

* remove bash options

* Update devops/scripts/load_and_validate_env.sh

Co-authored-by: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>

* Update devops/scripts/load_and_validate_env.sh

Co-authored-by: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>

---------

Co-authored-by: LizaShak <iliza@outlook.com>
Co-authored-by: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
LizaShak added a commit that referenced this pull request Apr 3, 2023
@yuvalyaron @LizaShak @tamirkamara
Move duplicated logic to scripts (#3371)
2e470e7 
* move construction of tre_url to script and source it

* Use Azure environment in local deployment

* move conversion of azure_env to arm_env to script and source it

* remove bash options

* Update devops/scripts/load_and_validate_env.sh

Co-authored-by: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>

* Update devops/scripts/load_and_validate_env.sh

Co-authored-by: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>

---------

Co-authored-by: LizaShak <iliza@outlook.com>
Co-authored-by: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
@azuretresussex
Copy link

Hello, I'm deploying an AzureTRE using deploy_tre.yml, and CICD currently failing with the following output.

Prepare all required actions
Getting action download info
Run ./.github/actions/devcontainer_run_command
Run azure_env="AzureCloud"
Run source devops/scripts/construct_tre_url.sh
/home/runner/work/_temp/15921fb8-6b7f-497f-88ed-b3e0210eea03.sh: line 1: devops/scripts/construct_tre_url.sh: No such file or directory
Error: Process completed with exit code 1.

Could this be related to the change described in #3371 ?

@marrobi
Copy link
Member

marrobi commented May 4, 2023

Hello, @azuretresussex , could you create a new issue for this query - https://github.com/microsoft/AzureTRE/issues ?

Also when you create the issue please confirm if you are using the AzureTRE-Deployment repository or the AzureTRE repository to deploy?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamirkamara tamirkamara tamirkamara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yuvalyaron @azuretresussex @marrobi @tamirkamara @LizaShak