Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add temporary workaround for when id with last 4 chars exists #3667

Merged
merged 12 commits into from
Sep 18, 2023

Conversation

marrobi
Copy link
Member

@marrobi marrobi commented Aug 10, 2023

Resolves #2893

  • Add function that checks for existance of worksapce_id with the same last 4 digits.
  • When generating worksapce_id while loop until none returned.

Overhead is limited, but improves experience until we have a full fix.

@marrobi marrobi enabled auto-merge (squash) August 10, 2023 15:40
@github-actions
Copy link

github-actions bot commented Aug 10, 2023

Unit Test Results

575 tests   575 ✔️  14s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit 050d8c6.

♻️ This comment has been updated with latest results.

@marrobi
Copy link
Member Author

marrobi commented Aug 24, 2023

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/5966519603 (with refid 44174b52)

(in response to this comment from @marrobi)

@marrobi
Copy link
Member Author

marrobi commented Sep 6, 2023

/test

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/6096303663 (with refid 44174b52)

(in response to this comment from @marrobi)

Copy link
Collaborator

@SvenAelterman SvenAelterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marrobi
Copy link
Member Author

marrobi commented Sep 7, 2023

/test-extended

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/6109096538 (with refid 44174b52)

(in response to this comment from @marrobi)

@marrobi
Copy link
Member Author

marrobi commented Sep 18, 2023

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 050d8c6)

(in response to this comment from @marrobi)

@marrobi marrobi merged commit 2bd71a0 into microsoft:main Sep 18, 2023
10 checks passed
@marrobi marrobi deleted the marrobi/issue2893 branch September 18, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workspace deploy fails because storage account is not unique
2 participants