-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add route to retrieve users assigned to a workspace with UI #4058
base: main
Are you sure you want to change the base?
Conversation
@jonnyry - or anyone else, if you fancy giving this a test, would welcome feedback. :) |
d98e945
to
accfc90
Compare
Unit Test Results596 tests 594 ✅ 7s ⏱️ Results for commit f4af0f9. ♻️ This comment has been updated with latest results. |
I did the designs a while ago where users in a workspace were shown using an avatar group on the workspace nav bar (design here) and also on the workspace card (here). Maybe not something you want to look at in this PR but could be a good way to display this |
name: string; | ||
email: string; | ||
role: string; | ||
roles: string[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
role
and roles
seems confusing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can i resolve this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test-extended |
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/10829416378 (with refid (in response to this comment from @tim-allen-ck) |
/test-extended |
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/11068239761 (with refid (in response to this comment from @tim-allen-ck) |
This pull request adds a new route to the
workspaces_shared_router
that allows users to retrieve the list of users assigned to a workspace. The route is/api/workspaces/{workspace_id}/users/
.The implementation uses the MS Graph API to retrieve the roles from the Enterprise Application. The API call
GET /servicePrincipals(appId='{appId}')/appRoleAssignedTo
is used to fetch the app roles assigned to the user.The response of the API includes the name, email, and app roles of each user. The user interface also includes a new section called "Users" in the left-hand menu under Airlock. This section displays the list of users with their name, email, and role(s).
Also updated and refactored some of the repitition in the aad tests.
Fixes #4049