Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multi-lang all up view refinement #3847

Merged
merged 12 commits into from
Aug 18, 2020
Merged

Conversation

zhixzhan
Copy link
Contributor

@zhixzhan zhixzhan commented Aug 14, 2020

Description

Some refinement in multiple language & all up view

  1. Search box for multiple languages
  2. Editable table list view
  3. Pretty column space.

Task Item

#minor

Screenshots

Search box for multiple languages

Untitled

Editable table list view

Untitled1

Columns space in 1920px
Untitled2

Columns space in 1280px
Untitled3

@boydc2014 boydc2014 changed the title fix: all up view refinement fix: multi-lang all up view refinement Aug 14, 2020
@coveralls
Copy link

coveralls commented Aug 14, 2020

Coverage Status

Coverage decreased (-0.2%) to 57.017% when pulling 4c7d13d on zhixzhan:refinement into b12756e on microsoft:main.

@zhixzhan
Copy link
Contributor Author

Hi @vivekkshankar , I updated few UX on above screenshots, if you have any suggestions please let me know, thanks !

@cwhitten
Copy link
Member

@zhixzhan In the tables the first column should be the short one and the comparison columns should take up the rest of the container's width, spaced evenly.

@zhixzhan
Copy link
Contributor Author

zhixzhan commented Aug 15, 2020

@zhixzhan In the tables the first column should be the short one and the comparison columns should take up the rest of the container's width, spaced evenly.

I searched the fluent ui documents but failed to find a way of accurately setting width, or something like css flex display. Supported props are minWidth & maxWidth. And the behavior is the first column didn't set maxWidth padding rest all spaces.
microsoft/fluentui#6973

So I set the columns width, and tested at 1280px/ 1980px, looks ok.

Name Phrase-lang1 Phrase-lang2
minWidth: 100 minWidth: 300 minWidth: 300
maxWidth: 200 maxWitdh: 500 / ** set Maxwidth **/ /** none maxWidth, will occupy rest spaces **/

@cwhitten cwhitten merged commit 1e09cb6 into microsoft:main Aug 18, 2020
@zhixzhan zhixzhan deleted the refinement branch August 19, 2020 02:04
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* search box for multilang adding

* pretty tablelist column space

* fine-grain updateTemplate

* when blur submit updated value

* refine api

* editable tablelist

* eable multiline

* update test

* adjust column width

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants