Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: in setting botId not consistence with MicrosoftAppId #4052

Merged
merged 4 commits into from
Sep 8, 2020
Merged

fix: in setting botId not consistence with MicrosoftAppId #4052

merged 4 commits into from
Sep 8, 2020

Conversation

zhixzhan
Copy link
Contributor

@zhixzhan zhixzhan commented Sep 7, 2020 •
edited
Loading

Description

Task Item

close #3849
close #3853

Screenshots

@coveralls
Copy link

coveralls commented Sep 7, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.009%) to 55.613% when pulling c43744f on zhixzhan/setting-fix into 313c40d on main.

cwhitten
cwhitten reviewed Sep 8, 2020
View reviewed changes
Composer/packages/client/src/pages/skills/skill-settings.tsx
setSkillSettings({ ...localSettings });
console.log('ehh', localSettings);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@cwhitten cwhitten merged commit 742d9cc into main Sep 8, 2020
@cwhitten cwhitten deleted the zhixzhan/setting-fix branch September 8, 2020 20:49
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
Merged
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@zhixzhan @a-b-r-o-w-n @cwhitten
auto fill botId with MicrosoftAppId (microsoft#4052)
3873c06 
Co-authored-by: Andy Brown <asbrown002@gmail.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwhitten cwhitten cwhitten left review comments

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n approved these changes

@beyackle beyackle Awaiting requested review from beyackle

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@srinaath srinaath Awaiting requested review from srinaath

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@zhixzhan @coveralls @cwhitten @a-b-r-o-w-n